package provisioning import ( "context" "errors" "fmt" "slices" "testing" "github.com/prometheus/alertmanager/config" "github.com/prometheus/alertmanager/timeinterval" "github.com/stretchr/testify/assert" "github.com/stretchr/testify/mock" "github.com/stretchr/testify/require" "github.com/grafana/grafana/pkg/infra/log" "github.com/grafana/grafana/pkg/services/ngalert/api/tooling/definitions" "github.com/grafana/grafana/pkg/services/ngalert/models" "github.com/grafana/grafana/pkg/services/ngalert/notifier/legacy_storage" ) func TestGetMuteTimings(t *testing.T) { orgID := int64(1) revision := &legacy_storage.ConfigRevision{ Config: &definitions.PostableUserConfig{ AlertmanagerConfig: definitions.PostableApiAlertingConfig{ Config: definitions.Config{ MuteTimeIntervals: []config.MuteTimeInterval{ { Name: "Test1", TimeIntervals: nil, }, { Name: "Test2", TimeIntervals: nil, }, }, TimeIntervals: []config.TimeInterval{ { Name: "Test3", TimeIntervals: nil, }, }, }, }, }, } provenances := map[string]models.Provenance{ "Test1": models.ProvenanceFile, "Test2": models.ProvenanceAPI, } t.Run("service returns timings from config file", func(t *testing.T) { sut, store, prov := createMuteTimingSvcSut() store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return revision, nil } prov.EXPECT().GetProvenances(mock.Anything, mock.Anything, mock.Anything).Return(provenances, nil) result, err := sut.GetMuteTimings(context.Background(), 1) require.NoError(t, err) require.Len(t, result, len(revision.Config.AlertmanagerConfig.MuteTimeIntervals)+len(revision.Config.AlertmanagerConfig.TimeIntervals)) require.Equal(t, "Test1", result[0].Name) require.EqualValues(t, provenances["Test1"], result[0].Provenance) require.NotEmpty(t, result[0].Version) require.Equal(t, legacy_storage.NameToUid(result[0].Name), result[0].UID) require.Equal(t, "Test2", result[1].Name) require.EqualValues(t, provenances["Test2"], result[1].Provenance) require.NotEmpty(t, result[1].Version) require.Equal(t, legacy_storage.NameToUid(result[1].Name), result[1].UID) require.Equal(t, "Test3", result[2].Name) require.EqualValues(t, "", result[2].Provenance) require.NotEmpty(t, result[2].Version) require.Equal(t, legacy_storage.NameToUid(result[2].Name), result[2].UID) require.Len(t, store.Calls, 1) require.Equal(t, "Get", store.Calls[0].Method) require.Equal(t, orgID, store.Calls[0].Args[1]) prov.AssertCalled(t, "GetProvenances", mock.Anything, orgID, (&definitions.MuteTimeInterval{}).ResourceType()) }) t.Run("service returns empty list when config file contains no mute timings", func(t *testing.T) { sut, store, _ := createMuteTimingSvcSut() store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return &legacy_storage.ConfigRevision{Config: &definitions.PostableUserConfig{}}, nil } result, err := sut.GetMuteTimings(context.Background(), 1) require.NoError(t, err) require.Empty(t, result) }) t.Run("service propagates errors", func(t *testing.T) { t.Run("when unable to read config", func(t *testing.T) { sut, store, _ := createMuteTimingSvcSut() expected := fmt.Errorf("failed") store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return nil, expected } _, err := sut.GetMuteTimings(context.Background(), orgID) require.ErrorIs(t, err, expected) }) t.Run("when unable to read provenance", func(t *testing.T) { sut, store, prov := createMuteTimingSvcSut() store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return revision, nil } expected := fmt.Errorf("failed") prov.EXPECT().GetProvenances(mock.Anything, mock.Anything, mock.Anything).Return(nil, expected) _, err := sut.GetMuteTimings(context.Background(), orgID) require.ErrorIs(t, err, expected) }) }) } func TestGetMuteTiming(t *testing.T) { orgID := int64(1) revision := &legacy_storage.ConfigRevision{ Config: &definitions.PostableUserConfig{ AlertmanagerConfig: definitions.PostableApiAlertingConfig{ Config: definitions.Config{ MuteTimeIntervals: []config.MuteTimeInterval{ { Name: "Test1", TimeIntervals: nil, }, }, TimeIntervals: []config.TimeInterval{ { Name: "Test2", TimeIntervals: nil, }, }, }, }, }, } t.Run("service returns timing by name", func(t *testing.T) { sut, store, prov := createMuteTimingSvcSut() store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return revision, nil } prov.EXPECT().GetProvenance(mock.Anything, mock.Anything, mock.Anything).Return(models.ProvenanceAPI, nil) result, err := sut.GetMuteTiming(context.Background(), "Test1", orgID) require.NoError(t, err) require.Equal(t, "Test1", result.Name) require.EqualValues(t, models.ProvenanceAPI, result.Provenance) require.Equal(t, legacy_storage.NameToUid(result.Name), result.UID) require.NotEmpty(t, result.Version) require.Len(t, store.Calls, 1) require.Equal(t, "Get", store.Calls[0].Method) require.Equal(t, orgID, store.Calls[0].Args[1]) prov.AssertCalled(t, "GetProvenance", mock.Anything, &result, orgID) t.Run("and by UID", func(t *testing.T) { result2, err := sut.GetMuteTiming(context.Background(), result.UID, orgID) require.NoError(t, err) require.Equal(t, result, result2) }) }) t.Run("service looks in both places", func(t *testing.T) { sut, store, prov := createMuteTimingSvcSut() store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return revision, nil } prov.EXPECT().GetProvenance(mock.Anything, mock.Anything, mock.Anything).Return(models.ProvenanceFile, nil) result, err := sut.GetMuteTiming(context.Background(), "Test2", orgID) require.NoError(t, err) require.Equal(t, "Test2", result.Name) require.EqualValues(t, models.ProvenanceFile, result.Provenance) require.Equal(t, legacy_storage.NameToUid(result.Name), result.UID) require.NotEmpty(t, result.Version) require.Len(t, store.Calls, 1) require.Equal(t, "Get", store.Calls[0].Method) require.Equal(t, orgID, store.Calls[0].Args[1]) prov.AssertCalled(t, "GetProvenance", mock.Anything, &result, orgID) t.Run("and by UID", func(t *testing.T) { result2, err := sut.GetMuteTiming(context.Background(), result.UID, orgID) require.NoError(t, err) require.Equal(t, result, result2) }) }) t.Run("service returns ErrTimeIntervalNotFound if no mute timings", func(t *testing.T) { sut, store, _ := createMuteTimingSvcSut() store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return &legacy_storage.ConfigRevision{Config: &definitions.PostableUserConfig{}}, nil } _, err := sut.GetMuteTiming(context.Background(), "Test1", orgID) require.Truef(t, ErrTimeIntervalNotFound.Is(err), "expected ErrTimeIntervalNotFound but got %s", err) }) t.Run("service returns ErrTimeIntervalNotFound if no mute timing by name", func(t *testing.T) { sut, store, _ := createMuteTimingSvcSut() store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return revision, nil } _, err := sut.GetMuteTiming(context.Background(), "Test123", orgID) require.Truef(t, ErrTimeIntervalNotFound.Is(err), "expected ErrTimeIntervalNotFound but got %s", err) }) t.Run("service propagates errors", func(t *testing.T) { t.Run("when unable to read config", func(t *testing.T) { sut, store, _ := createMuteTimingSvcSut() expected := fmt.Errorf("failed") store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return nil, expected } _, err := sut.GetMuteTiming(context.Background(), "Test1", orgID) require.ErrorIs(t, err, expected) }) t.Run("when unable to read provenance", func(t *testing.T) { sut, store, prov := createMuteTimingSvcSut() store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return revision, nil } expected := fmt.Errorf("failed") prov.EXPECT().GetProvenance(mock.Anything, mock.Anything, mock.Anything).Return("", expected) _, err := sut.GetMuteTiming(context.Background(), "Test1", orgID) require.ErrorIs(t, err, expected) }) }) } func TestCreateMuteTimings(t *testing.T) { orgID := int64(1) initialConfig := func() *definitions.PostableUserConfig { return &definitions.PostableUserConfig{ TemplateFiles: nil, AlertmanagerConfig: definitions.PostableApiAlertingConfig{ Config: definitions.Config{ MuteTimeIntervals: []config.MuteTimeInterval{ { Name: "TEST", }, }, TimeIntervals: []config.TimeInterval{ { Name: "TEST2", }, }, }, Receivers: nil, }, } } expected := config.MuteTimeInterval{ Name: "Test", TimeIntervals: []timeinterval.TimeInterval{ { Times: []timeinterval.TimeRange{ { StartMinute: 10, EndMinute: 60, }, }, }, }, } expectedProvenance := models.ProvenanceAPI timing := definitions.MuteTimeInterval{ MuteTimeInterval: expected, Provenance: definitions.Provenance(expectedProvenance), } t.Run("returns ErrTimeIntervalInvalid if mute timings fail validation", func(t *testing.T) { sut, _, _ := createMuteTimingSvcSut() timing := definitions.MuteTimeInterval{ MuteTimeInterval: config.MuteTimeInterval{ Name: "", }, Provenance: definitions.Provenance(models.ProvenanceFile), } _, err := sut.CreateMuteTiming(context.Background(), timing, orgID) require.Truef(t, ErrTimeIntervalInvalid.Base.Is(err), "expected ErrTimeIntervalInvalid but got %s", err) }) t.Run("returns ErrTimeIntervalExists if mute timing with the name exists", func(t *testing.T) { sut, store, _ := createMuteTimingSvcSut() store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return &legacy_storage.ConfigRevision{Config: initialConfig()}, nil } existing := initialConfig().AlertmanagerConfig.MuteTimeIntervals[0] timing := definitions.MuteTimeInterval{ MuteTimeInterval: existing, Provenance: definitions.Provenance(models.ProvenanceFile), } _, err := sut.CreateMuteTiming(context.Background(), timing, orgID) require.Truef(t, ErrTimeIntervalExists.Is(err), "expected ErrTimeIntervalExists but got %s", err) existing = config.MuteTimeInterval(initialConfig().AlertmanagerConfig.TimeIntervals[0]) timing = definitions.MuteTimeInterval{ MuteTimeInterval: existing, Provenance: definitions.Provenance(models.ProvenanceFile), } _, err = sut.CreateMuteTiming(context.Background(), timing, orgID) require.Truef(t, ErrTimeIntervalExists.Is(err), "expected ErrTimeIntervalExists but got %s", err) }) t.Run("saves mute timing and provenance in a transaction", func(t *testing.T) { sut, store, prov := createMuteTimingSvcSut() store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return &legacy_storage.ConfigRevision{Config: initialConfig()}, nil } store.SaveFn = func(ctx context.Context, revision *legacy_storage.ConfigRevision) error { assertInTransaction(t, ctx) return nil } prov.EXPECT().SetProvenance(mock.Anything, mock.Anything, mock.Anything, mock.Anything).RunAndReturn( func(ctx context.Context, _ models.Provisionable, _ int64, _ models.Provenance) error { assertInTransaction(t, ctx) return nil }) result, err := sut.CreateMuteTiming(context.Background(), timing, orgID) require.NoError(t, err) require.EqualValues(t, expected, result.MuteTimeInterval) require.EqualValues(t, expectedProvenance, result.Provenance) require.Equal(t, legacy_storage.NameToUid(expected.Name), result.UID) require.NotEmpty(t, result.Version) require.Len(t, store.Calls, 2) require.Equal(t, "Get", store.Calls[0].Method) require.Equal(t, orgID, store.Calls[0].Args[1]) require.Equal(t, "Save", store.Calls[1].Method) require.Equal(t, orgID, store.Calls[1].Args[2]) revision := store.Calls[1].Args[1].(*legacy_storage.ConfigRevision) expectedTimings := append(initialConfig().AlertmanagerConfig.TimeIntervals, config.TimeInterval(expected)) require.EqualValues(t, expectedTimings, revision.Config.AlertmanagerConfig.TimeIntervals) prov.AssertCalled(t, "SetProvenance", mock.Anything, &timing, orgID, expectedProvenance) }) t.Run("propagates errors", func(t *testing.T) { t.Run("when unable to read config", func(t *testing.T) { sut, store, _ := createMuteTimingSvcSut() expectedErr := errors.New("test-err") store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return nil, expectedErr } _, err := sut.CreateMuteTiming(context.Background(), timing, orgID) require.ErrorIs(t, err, expectedErr) }) t.Run("when provenance fails to save", func(t *testing.T) { sut, store, _ := createMuteTimingSvcSut() store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return &legacy_storage.ConfigRevision{Config: initialConfig()}, nil } expectedErr := fmt.Errorf("failed to save provenance") sut.provenanceStore.(*MockProvisioningStore).EXPECT(). SetProvenance(mock.Anything, mock.Anything, mock.Anything, mock.Anything). Return(expectedErr) _, err := sut.CreateMuteTiming(context.Background(), timing, orgID) require.ErrorIs(t, err, expectedErr) require.Len(t, store.Calls, 2) require.Equal(t, "Get", store.Calls[0].Method) require.Equal(t, orgID, store.Calls[0].Args[1]) require.Equal(t, "Save", store.Calls[1].Method) }) t.Run("when AM config fails to save", func(t *testing.T) { sut, store, _ := createMuteTimingSvcSut() store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return &legacy_storage.ConfigRevision{Config: initialConfig()}, nil } expectedErr := errors.New("test-err") store.SaveFn = func(ctx context.Context, revision *legacy_storage.ConfigRevision) error { return expectedErr } _, err := sut.CreateMuteTiming(context.Background(), timing, orgID) require.ErrorIs(t, err, expectedErr) require.Len(t, store.Calls, 2) require.Equal(t, "Get", store.Calls[0].Method) require.Equal(t, orgID, store.Calls[0].Args[1]) require.Equal(t, "Save", store.Calls[1].Method) }) }) } func TestUpdateMuteTimings(t *testing.T) { orgID := int64(1) original := config.MuteTimeInterval{ Name: "Test", } originalVersion := calculateMuteTimeIntervalFingerprint(original) initialConfig := func() *definitions.PostableUserConfig { return &definitions.PostableUserConfig{ TemplateFiles: nil, AlertmanagerConfig: definitions.PostableApiAlertingConfig{ Config: definitions.Config{ MuteTimeIntervals: []config.MuteTimeInterval{ original, }, TimeIntervals: []config.TimeInterval{ { Name: "Test2", }, }, Route: &definitions.Route{ Routes: []*definitions.Route{ { MuteTimeIntervals: []string{original.Name}, }, }, }, }, Receivers: nil, }, } } expected := config.MuteTimeInterval{ Name: "Test", TimeIntervals: []timeinterval.TimeInterval{ { Times: []timeinterval.TimeRange{ { StartMinute: 10, EndMinute: 60, }, }, }, }, } expectedProvenance := models.ProvenanceAPI expectedVersion := calculateMuteTimeIntervalFingerprint(expected) expectedUID := legacy_storage.NameToUid(expected.Name) timing := definitions.MuteTimeInterval{ MuteTimeInterval: expected, Version: originalVersion, Provenance: definitions.Provenance(expectedProvenance), } t.Run("rejects mute timings that fail validation", func(t *testing.T) { sut, _, _ := createMuteTimingSvcSut() timing := definitions.MuteTimeInterval{ MuteTimeInterval: config.MuteTimeInterval{ Name: "", }, Provenance: definitions.Provenance(models.ProvenanceFile), } _, err := sut.UpdateMuteTiming(context.Background(), timing, orgID) require.Truef(t, ErrTimeIntervalInvalid.Base.Is(err), "expected ErrTimeIntervalInvalid but got %s", err) }) t.Run("rejects mute timings if provenance is not right", func(t *testing.T) { sut, store, prov := createMuteTimingSvcSut() store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return &legacy_storage.ConfigRevision{Config: initialConfig()}, nil } expectedErr := errors.New("test") sut.validator = func(from, to models.Provenance) error { return expectedErr } timing := definitions.MuteTimeInterval{ MuteTimeInterval: expected, Provenance: definitions.Provenance(models.ProvenanceFile), } prov.EXPECT().GetProvenance(mock.Anything, mock.Anything, mock.Anything).Return(expectedProvenance, nil) _, err := sut.UpdateMuteTiming(context.Background(), timing, orgID) require.ErrorIs(t, err, expectedErr) }) t.Run("returns ErrVersionConflict if storage version does not match", func(t *testing.T) { sut, store, prov := createMuteTimingSvcSut() store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return &legacy_storage.ConfigRevision{Config: initialConfig()}, nil } timing := definitions.MuteTimeInterval{ MuteTimeInterval: expected, Version: "some_random_version", Provenance: definitions.Provenance(expectedProvenance), } prov.EXPECT().GetProvenance(mock.Anything, mock.Anything, mock.Anything).Return(expectedProvenance, nil) _, err := sut.UpdateMuteTiming(context.Background(), timing, orgID) require.ErrorIs(t, err, ErrVersionConflict) }) t.Run("returns ErrMuteTimingsNotFound if mute timing does not exist", func(t *testing.T) { sut, store, prov := createMuteTimingSvcSut() store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return &legacy_storage.ConfigRevision{Config: initialConfig()}, nil } prov.EXPECT().GetProvenance(mock.Anything, mock.Anything, mock.Anything).Return(expectedProvenance, nil) t.Run("when UID is specified", func(t *testing.T) { timing := definitions.MuteTimeInterval{ UID: "not-found", MuteTimeInterval: expected, Provenance: definitions.Provenance(expectedProvenance), } _, err := sut.UpdateMuteTiming(context.Background(), timing, orgID) require.ErrorIs(t, err, ErrTimeIntervalNotFound) }) t.Run("when only Name is specified", func(t *testing.T) { timing := definitions.MuteTimeInterval{ MuteTimeInterval: config.MuteTimeInterval{ Name: "not-found", }, Provenance: definitions.Provenance(expectedProvenance), } _, err := sut.UpdateMuteTiming(context.Background(), timing, orgID) require.ErrorIs(t, err, ErrTimeIntervalNotFound) }) }) t.Run("saves mute timing and provenance in a transaction if optimistic concurrency passes", func(t *testing.T) { sut, store, prov := createMuteTimingSvcSut() store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return &legacy_storage.ConfigRevision{Config: initialConfig()}, nil } store.SaveFn = func(ctx context.Context, revision *legacy_storage.ConfigRevision) error { assertInTransaction(t, ctx) return nil } prov.EXPECT().GetProvenance(mock.Anything, mock.Anything, mock.Anything).Return(expectedProvenance, nil) prov.EXPECT().SetProvenance(mock.Anything, mock.Anything, mock.Anything, mock.Anything).RunAndReturn( func(ctx context.Context, _ models.Provisionable, _ int64, _ models.Provenance) error { assertInTransaction(t, ctx) return nil }) result, err := sut.UpdateMuteTiming(context.Background(), timing, orgID) require.NoError(t, err) require.EqualValues(t, expected, result.MuteTimeInterval) require.EqualValues(t, expectedProvenance, result.Provenance) require.EqualValues(t, expectedVersion, result.Version) require.Equal(t, legacy_storage.NameToUid(result.Name), result.UID) require.Len(t, store.Calls, 2) require.Equal(t, "Get", store.Calls[0].Method) require.Equal(t, orgID, store.Calls[0].Args[1]) require.Equal(t, "Save", store.Calls[1].Method) require.Equal(t, orgID, store.Calls[1].Args[2]) revision := store.Calls[1].Args[1].(*legacy_storage.ConfigRevision) require.EqualValues(t, []config.MuteTimeInterval{expected}, revision.Config.AlertmanagerConfig.MuteTimeIntervals) prov.AssertCalled(t, "SetProvenance", mock.Anything, &timing, orgID, expectedProvenance) t.Run("bypass optimistic concurrency check if version is empty", func(t *testing.T) { store.Calls = nil timing := definitions.MuteTimeInterval{ MuteTimeInterval: config.MuteTimeInterval{ Name: expected.Name, TimeIntervals: []timeinterval.TimeInterval{ {Months: []timeinterval.MonthRange{ { InclusiveRange: timeinterval.InclusiveRange{ Begin: 1, End: 10, }, }, }}, }, }, Version: "", Provenance: definitions.Provenance(expectedProvenance), } expectedVersion := calculateMuteTimeIntervalFingerprint(timing.MuteTimeInterval) result, err := sut.UpdateMuteTiming(context.Background(), timing, orgID) require.NoError(t, err) require.EqualValues(t, timing.MuteTimeInterval, result.MuteTimeInterval) require.Equal(t, expectedVersion, result.Version) require.EqualValues(t, expectedProvenance, result.Provenance) require.Equal(t, "Save", store.Calls[1].Method) require.Equal(t, orgID, store.Calls[1].Args[2]) revision := store.Calls[1].Args[1].(*legacy_storage.ConfigRevision) require.EqualValues(t, []config.MuteTimeInterval{timing.MuteTimeInterval}, revision.Config.AlertmanagerConfig.MuteTimeIntervals) }) }) t.Run("updates time interval where it is", func(t *testing.T) { sut, store, prov := createMuteTimingSvcSut() store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return &legacy_storage.ConfigRevision{Config: initialConfig()}, nil } store.SaveFn = func(ctx context.Context, revision *legacy_storage.ConfigRevision) error { assertInTransaction(t, ctx) return nil } prov.EXPECT().GetProvenance(mock.Anything, mock.Anything, mock.Anything).Return(expectedProvenance, nil) prov.EXPECT().SetProvenance(mock.Anything, mock.Anything, mock.Anything, mock.Anything).RunAndReturn( func(ctx context.Context, _ models.Provisionable, _ int64, _ models.Provenance) error { assertInTransaction(t, ctx) return nil }) original := config.MuteTimeInterval(initialConfig().AlertmanagerConfig.TimeIntervals[0]) expected := expected expected.Name = original.Name timing := timing timing.MuteTimeInterval = expected timing.Version = calculateMuteTimeIntervalFingerprint(original) expectedVersion := calculateMuteTimeIntervalFingerprint(expected) result, err := sut.UpdateMuteTiming(context.Background(), timing, orgID) require.NoError(t, err) require.EqualValues(t, expected, result.MuteTimeInterval) require.EqualValues(t, expectedProvenance, result.Provenance) require.EqualValues(t, expectedVersion, result.Version) require.Equal(t, legacy_storage.NameToUid(result.Name), result.UID) require.Len(t, store.Calls, 2) require.Equal(t, "Get", store.Calls[0].Method) require.Equal(t, orgID, store.Calls[0].Args[1]) require.Equal(t, "Save", store.Calls[1].Method) require.Equal(t, orgID, store.Calls[1].Args[2]) revision := store.Calls[1].Args[1].(*legacy_storage.ConfigRevision) require.EqualValues(t, []config.TimeInterval{config.TimeInterval(expected)}, revision.Config.AlertmanagerConfig.TimeIntervals) prov.AssertCalled(t, "SetProvenance", mock.Anything, &timing, orgID, expectedProvenance) }) t.Run("renames interval and all its dependencies", func(t *testing.T) { sut, store, prov := createMuteTimingSvcSut() store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return &legacy_storage.ConfigRevision{Config: initialConfig()}, nil } store.SaveFn = func(ctx context.Context, revision *legacy_storage.ConfigRevision) error { assertInTransaction(t, ctx) return nil } prov.EXPECT().GetProvenance(mock.Anything, mock.Anything, mock.Anything).Return(expectedProvenance, nil) prov.EXPECT().DeleteProvenance(mock.Anything, mock.Anything, mock.Anything).RunAndReturn(func(ctx context.Context, provisionable models.Provisionable, i int64) error { assertInTransaction(t, ctx) return nil }) prov.EXPECT().SetProvenance(mock.Anything, mock.Anything, mock.Anything, mock.Anything).RunAndReturn( func(ctx context.Context, _ models.Provisionable, _ int64, _ models.Provenance) error { assertInTransaction(t, ctx) return nil }) ruleStore := &fakeAlertRuleNotificationStore{ RenameTimeIntervalInNotificationSettingsFn: func(ctx context.Context, orgID int64, old, new string, validate func(models.Provenance) bool, dryRun bool) ([]models.AlertRuleKey, []models.AlertRuleKey, error) { assertInTransaction(t, ctx) return nil, nil, nil }, } sut.ruleNotificationsStore = ruleStore interval := expected interval.Name = "another-time-interval" timing := definitions.MuteTimeInterval{ UID: expectedUID, MuteTimeInterval: interval, Version: originalVersion, Provenance: definitions.Provenance(expectedProvenance), } result, err := sut.UpdateMuteTiming(context.Background(), timing, orgID) require.NoError(t, err) require.EqualValues(t, interval, result.MuteTimeInterval) require.EqualValues(t, expectedProvenance, result.Provenance) require.EqualValues(t, calculateMuteTimeIntervalFingerprint(interval), result.Version) require.Equal(t, legacy_storage.NameToUid(result.Name), result.UID) require.Len(t, ruleStore.Calls, 1) assert.Equal(t, "RenameTimeIntervalInNotificationSettings", ruleStore.Calls[0].Method) assert.Equal(t, orgID, ruleStore.Calls[0].Args[1]) assert.Equal(t, original.Name, ruleStore.Calls[0].Args[2]) assert.Equal(t, interval.Name, ruleStore.Calls[0].Args[3]) assert.NotNil(t, ruleStore.Calls[0].Args[4]) assert.False(t, ruleStore.Calls[0].Args[5].(bool)) prov.AssertCalled(t, "SetProvenance", mock.Anything, mock.MatchedBy(func(m *definitions.MuteTimeInterval) bool { return m.Name == interval.Name }), orgID, expectedProvenance) prov.AssertCalled(t, "DeleteProvenance", mock.Anything, mock.MatchedBy(func(m *definitions.MuteTimeInterval) bool { return m.Name == original.Name }), orgID) prov.AssertExpectations(t) require.Len(t, store.Calls, 2) require.Equal(t, "Get", store.Calls[0].Method) assert.Equal(t, orgID, store.Calls[0].Args[1]) require.Equal(t, "Save", store.Calls[1].Method) assert.Equal(t, orgID, store.Calls[1].Args[2]) revision := store.Calls[1].Args[1].(*legacy_storage.ConfigRevision) assert.EqualValues(t, append(initialConfig().AlertmanagerConfig.TimeIntervals, config.TimeInterval(interval)), revision.Config.AlertmanagerConfig.TimeIntervals) assert.Falsef(t, isMuteTimeInUseInRoutes(expected.Name, revision.Config.AlertmanagerConfig.Route), "There are still references to the old time interval") assert.Truef(t, isMuteTimeInUseInRoutes(interval.Name, revision.Config.AlertmanagerConfig.Route), "There are no references to the new time interval") }) t.Run("returns ErrTimeIntervalDependentResourcesProvenance if route has different provenance status", func(t *testing.T) { sut, store, prov := createMuteTimingSvcSut() store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return &legacy_storage.ConfigRevision{Config: initialConfig()}, nil } prov.EXPECT().GetProvenance(mock.Anything, mock.MatchedBy(func(*definitions.Route) bool { return true }), mock.Anything).Return(models.ProvenanceFile, nil) prov.EXPECT().GetProvenance(mock.Anything, mock.Anything, mock.Anything).Return(expectedProvenance, nil) ruleStore := &fakeAlertRuleNotificationStore{ RenameTimeIntervalInNotificationSettingsFn: func(ctx context.Context, orgID int64, old, new string, validate func(models.Provenance) bool, dryRun bool) ([]models.AlertRuleKey, []models.AlertRuleKey, error) { assertInTransaction(t, ctx) return nil, nil, nil }, } sut.ruleNotificationsStore = ruleStore interval := expected interval.Name = "another-time-interval" timing := definitions.MuteTimeInterval{ UID: expectedUID, MuteTimeInterval: interval, Version: originalVersion, Provenance: definitions.Provenance(expectedProvenance), } _, err := sut.UpdateMuteTiming(context.Background(), timing, orgID) require.ErrorIs(t, err, ErrTimeIntervalDependentResourcesProvenance) require.Len(t, ruleStore.Calls, 1) assert.Equal(t, "RenameTimeIntervalInNotificationSettings", ruleStore.Calls[0].Method) assert.Equal(t, orgID, ruleStore.Calls[0].Args[1]) assert.Equal(t, original.Name, ruleStore.Calls[0].Args[2]) assert.Equal(t, interval.Name, ruleStore.Calls[0].Args[3]) assert.NotNil(t, ruleStore.Calls[0].Args[4]) assert.True(t, ruleStore.Calls[0].Args[5].(bool)) // still check if there are rules that have incompatible provenance }) t.Run("returns ErrTimeIntervalDependentResourcesProvenance if rules have different provenance status", func(t *testing.T) { sut, store, prov := createMuteTimingSvcSut() store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return &legacy_storage.ConfigRevision{Config: initialConfig()}, nil } prov.EXPECT().GetProvenance(mock.Anything, mock.MatchedBy(func(*definitions.Route) bool { return true }), mock.Anything).Return(models.ProvenanceNone, nil) prov.EXPECT().GetProvenance(mock.Anything, mock.Anything, mock.Anything).Return(expectedProvenance, nil) ruleStore := &fakeAlertRuleNotificationStore{ RenameTimeIntervalInNotificationSettingsFn: func(ctx context.Context, orgID int64, old, new string, validate func(models.Provenance) bool, dryRun bool) ([]models.AlertRuleKey, []models.AlertRuleKey, error) { assertInTransaction(t, ctx) return nil, []models.AlertRuleKey{models.GenerateRuleKey(orgID)}, nil }, } sut.ruleNotificationsStore = ruleStore interval := expected interval.Name = "another-time-interval" timing := definitions.MuteTimeInterval{ UID: expectedUID, MuteTimeInterval: interval, Version: originalVersion, Provenance: definitions.Provenance(expectedProvenance), } _, err := sut.UpdateMuteTiming(context.Background(), timing, orgID) require.ErrorIs(t, err, ErrTimeIntervalDependentResourcesProvenance) require.Len(t, ruleStore.Calls, 1) assert.Equal(t, "RenameTimeIntervalInNotificationSettings", ruleStore.Calls[0].Method) assert.Equal(t, orgID, ruleStore.Calls[0].Args[1]) assert.Equal(t, original.Name, ruleStore.Calls[0].Args[2]) assert.Equal(t, interval.Name, ruleStore.Calls[0].Args[3]) assert.NotNil(t, ruleStore.Calls[0].Args[4]) assert.False(t, ruleStore.Calls[0].Args[5].(bool)) }) t.Run("propagates errors", func(t *testing.T) { t.Run("when unable to read config", func(t *testing.T) { sut, store, prov := createMuteTimingSvcSut() expectedErr := errors.New("test-err") prov.EXPECT().GetProvenance(mock.Anything, mock.Anything, mock.Anything).Return(expectedProvenance, nil) store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return nil, expectedErr } _, err := sut.UpdateMuteTiming(context.Background(), timing, orgID) require.ErrorIs(t, err, expectedErr) }) t.Run("when provenance fails to save", func(t *testing.T) { sut, store, _ := createMuteTimingSvcSut() store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return &legacy_storage.ConfigRevision{Config: initialConfig()}, nil } expectedErr := fmt.Errorf("failed to save provenance") sut.provenanceStore.(*MockProvisioningStore).EXPECT(). GetProvenance(mock.Anything, mock.Anything, mock.Anything). Return(expectedProvenance, nil) sut.provenanceStore.(*MockProvisioningStore).EXPECT(). SetProvenance(mock.Anything, mock.Anything, mock.Anything, mock.Anything). Return(expectedErr) _, err := sut.UpdateMuteTiming(context.Background(), timing, orgID) require.ErrorIs(t, err, expectedErr) require.Len(t, store.Calls, 2) require.Equal(t, "Get", store.Calls[0].Method) require.Equal(t, orgID, store.Calls[0].Args[1]) require.Equal(t, "Save", store.Calls[1].Method) }) t.Run("when AM config fails to save", func(t *testing.T) { sut, store, _ := createMuteTimingSvcSut() store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return &legacy_storage.ConfigRevision{Config: initialConfig()}, nil } sut.provenanceStore.(*MockProvisioningStore).EXPECT(). GetProvenance(mock.Anything, mock.Anything, mock.Anything). Return(expectedProvenance, nil) expectedErr := errors.New("test-err") store.SaveFn = func(ctx context.Context, revision *legacy_storage.ConfigRevision) error { return expectedErr } _, err := sut.UpdateMuteTiming(context.Background(), timing, orgID) require.ErrorIs(t, err, expectedErr) require.Len(t, store.Calls, 2) require.Equal(t, "Get", store.Calls[0].Method) require.Equal(t, orgID, store.Calls[0].Args[1]) require.Equal(t, "Save", store.Calls[1].Method) }) t.Run("when RenameTimeIntervalInNotificationSettings fails", func(t *testing.T) { sut, store, prov := createMuteTimingSvcSut() store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return &legacy_storage.ConfigRevision{Config: initialConfig()}, nil } prov.EXPECT().GetProvenance(mock.Anything, mock.Anything, mock.Anything).Return(expectedProvenance, nil) prov.EXPECT().DeleteProvenance(mock.Anything, mock.Anything, mock.Anything).Return(nil) prov.EXPECT().SetProvenance(mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(nil) expectedErr := errors.New("test-err") ruleStore := &fakeAlertRuleNotificationStore{ RenameTimeIntervalInNotificationSettingsFn: func(ctx context.Context, orgID int64, old, new string, validate func(models.Provenance) bool, dryRun bool) ([]models.AlertRuleKey, []models.AlertRuleKey, error) { return nil, nil, expectedErr }, } sut.ruleNotificationsStore = ruleStore interval := expected interval.Name = "another-time-interval" timing := definitions.MuteTimeInterval{ UID: expectedUID, MuteTimeInterval: interval, Version: originalVersion, Provenance: definitions.Provenance(expectedProvenance), } _, err := sut.UpdateMuteTiming(context.Background(), timing, orgID) require.ErrorIs(t, err, expectedErr) }) }) } func TestDeleteMuteTimings(t *testing.T) { orgID := int64(1) timingToDelete := config.MuteTimeInterval{Name: "unused-timing"} correctVersion := calculateMuteTimeIntervalFingerprint(timingToDelete) usedTiming := "used-timing" initialConfig := func() *definitions.PostableUserConfig { return &definitions.PostableUserConfig{ TemplateFiles: nil, AlertmanagerConfig: definitions.PostableApiAlertingConfig{ Config: definitions.Config{ Route: &definitions.Route{ MuteTimeIntervals: []string{usedTiming}, }, MuteTimeIntervals: []config.MuteTimeInterval{ { Name: usedTiming, }, timingToDelete, }, TimeIntervals: []config.TimeInterval{ { Name: "timing-to-delete2", }, }, }, Receivers: nil, }, } } t.Run("fails if provenance check fails", func(t *testing.T) { sut, store, prov := createMuteTimingSvcSut() expectedErr := errors.New("test") sut.validator = func(from, to models.Provenance) error { return expectedErr } store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return &legacy_storage.ConfigRevision{Config: initialConfig()}, nil } prov.EXPECT().GetProvenance(mock.Anything, mock.Anything, mock.Anything).Return(models.ProvenanceAPI, nil) err := sut.DeleteMuteTiming(context.Background(), timingToDelete.Name, orgID, definitions.Provenance(models.ProvenanceNone), correctVersion) require.ErrorIs(t, err, expectedErr) }) t.Run("returns ErrTimeIntervalInUse if mute timing is used by a route", func(t *testing.T) { sut, store, prov := createMuteTimingSvcSut() store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return &legacy_storage.ConfigRevision{Config: initialConfig()}, nil } prov.EXPECT().GetProvenance(mock.Anything, mock.Anything, mock.Anything).Return(models.ProvenanceAPI, nil) err := sut.DeleteMuteTiming(context.Background(), usedTiming, orgID, definitions.Provenance(models.ProvenanceAPI), correctVersion) require.Len(t, store.Calls, 1) require.Equal(t, "Get", store.Calls[0].Method) require.Equal(t, orgID, store.Calls[0].Args[1]) require.ErrorIs(t, err, ErrTimeIntervalInUse) }) t.Run("returns ErrTimeIntervalInUse if mute timing is used by rules", func(t *testing.T) { sut, store, prov := createMuteTimingSvcSut() ruleNsStore := fakeAlertRuleNotificationStore{ ListNotificationSettingsFn: func(ctx context.Context, q models.ListNotificationSettingsQuery) (map[models.AlertRuleKey][]models.NotificationSettings, error) { assertInTransaction(t, ctx) assert.Equal(t, orgID, q.OrgID) assert.Equal(t, timingToDelete.Name, q.TimeIntervalName) assert.Empty(t, q.ReceiverName) return map[models.AlertRuleKey][]models.NotificationSettings{ models.GenerateRuleKey(orgID): nil, }, nil }, } sut.ruleNotificationsStore = &ruleNsStore store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return &legacy_storage.ConfigRevision{Config: initialConfig()}, nil } prov.EXPECT().GetProvenance(mock.Anything, mock.Anything, mock.Anything).Return(models.ProvenanceAPI, nil) err := sut.DeleteMuteTiming(context.Background(), timingToDelete.Name, orgID, definitions.Provenance(models.ProvenanceAPI), correctVersion) require.Len(t, store.Calls, 1) require.Equal(t, "Get", store.Calls[0].Method) require.Equal(t, orgID, store.Calls[0].Args[1]) require.ErrorIs(t, err, ErrTimeIntervalInUse) require.Len(t, ruleNsStore.Calls, 1) require.Equal(t, "ListNotificationSettings", ruleNsStore.Calls[0].Method) }) t.Run("returns ErrVersionConflict if provided version does not match", func(t *testing.T) { sut, store, prov := createMuteTimingSvcSut() store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return &legacy_storage.ConfigRevision{Config: initialConfig()}, nil } prov.EXPECT().GetProvenance(mock.Anything, mock.Anything, mock.Anything).Return(models.ProvenanceAPI, nil) err := sut.DeleteMuteTiming(context.Background(), timingToDelete.Name, orgID, definitions.Provenance(models.ProvenanceAPI), "test-version") require.Len(t, store.Calls, 1) require.Equal(t, "Get", store.Calls[0].Method) require.Equal(t, orgID, store.Calls[0].Args[1]) require.ErrorIs(t, err, ErrVersionConflict) }) t.Run("deletes mute timing and provenance in transaction if passes optimistic concurrency check", func(t *testing.T) { sut, store, prov := createMuteTimingSvcSut() store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return &legacy_storage.ConfigRevision{Config: initialConfig()}, nil } store.SaveFn = func(ctx context.Context, revision *legacy_storage.ConfigRevision) error { assertInTransaction(t, ctx) return nil } prov.EXPECT().GetProvenance(mock.Anything, mock.Anything, mock.Anything).Return(models.ProvenanceNone, nil) prov.EXPECT().DeleteProvenance(mock.Anything, mock.Anything, mock.Anything).RunAndReturn( func(ctx context.Context, _ models.Provisionable, _ int64) error { assertInTransaction(t, ctx) return nil }) err := sut.DeleteMuteTiming(context.Background(), timingToDelete.Name, orgID, "", correctVersion) require.NoError(t, err) require.Len(t, store.Calls, 2) require.Equal(t, "Get", store.Calls[0].Method) require.Equal(t, orgID, store.Calls[0].Args[1]) require.Equal(t, "Save", store.Calls[1].Method) require.Equal(t, orgID, store.Calls[1].Args[2]) revision := store.Calls[1].Args[1].(*legacy_storage.ConfigRevision) expectedMuteTimings := slices.DeleteFunc(initialConfig().AlertmanagerConfig.MuteTimeIntervals, func(interval config.MuteTimeInterval) bool { return interval.Name == timingToDelete.Name }) require.EqualValues(t, expectedMuteTimings, revision.Config.AlertmanagerConfig.MuteTimeIntervals) prov.AssertCalled(t, "DeleteProvenance", mock.Anything, &definitions.MuteTimeInterval{MuteTimeInterval: timingToDelete}, orgID) t.Run("should bypass optimistic concurrency check if version is empty", func(t *testing.T) { store.Calls = nil err := sut.DeleteMuteTiming(context.Background(), timingToDelete.Name, orgID, "", "") require.NoError(t, err) require.Equal(t, "Save", store.Calls[1].Method) require.Equal(t, orgID, store.Calls[1].Args[2]) revision := store.Calls[1].Args[1].(*legacy_storage.ConfigRevision) expectedMuteTimings := slices.DeleteFunc(initialConfig().AlertmanagerConfig.MuteTimeIntervals, func(interval config.MuteTimeInterval) bool { return interval.Name == timingToDelete.Name }) require.EqualValues(t, expectedMuteTimings, revision.Config.AlertmanagerConfig.MuteTimeIntervals) prov.AssertCalled(t, "DeleteProvenance", mock.Anything, &definitions.MuteTimeInterval{MuteTimeInterval: timingToDelete}, orgID) }) }) t.Run("deletes time interval and provenance", func(t *testing.T) { sut, store, prov := createMuteTimingSvcSut() store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return &legacy_storage.ConfigRevision{Config: initialConfig()}, nil } store.SaveFn = func(ctx context.Context, revision *legacy_storage.ConfigRevision) error { assertInTransaction(t, ctx) return nil } prov.EXPECT().GetProvenance(mock.Anything, mock.Anything, mock.Anything).Return(models.ProvenanceNone, nil) prov.EXPECT().DeleteProvenance(mock.Anything, mock.Anything, mock.Anything).RunAndReturn( func(ctx context.Context, _ models.Provisionable, _ int64) error { assertInTransaction(t, ctx) return nil }) timingToDelete := initialConfig().AlertmanagerConfig.TimeIntervals[0] correctVersion := calculateMuteTimeIntervalFingerprint(config.MuteTimeInterval(timingToDelete)) err := sut.DeleteMuteTiming(context.Background(), timingToDelete.Name, orgID, "", correctVersion) require.NoError(t, err) require.Len(t, store.Calls, 2) require.Equal(t, "Get", store.Calls[0].Method) require.Equal(t, orgID, store.Calls[0].Args[1]) require.Equal(t, "Save", store.Calls[1].Method) require.Equal(t, orgID, store.Calls[1].Args[2]) revision := store.Calls[1].Args[1].(*legacy_storage.ConfigRevision) expectedMuteTimings := slices.DeleteFunc(initialConfig().AlertmanagerConfig.TimeIntervals, func(interval config.TimeInterval) bool { return interval.Name == timingToDelete.Name }) require.EqualValues(t, expectedMuteTimings, revision.Config.AlertmanagerConfig.TimeIntervals) require.EqualValues(t, initialConfig().AlertmanagerConfig.MuteTimeIntervals, revision.Config.AlertmanagerConfig.MuteTimeIntervals) prov.AssertCalled(t, "DeleteProvenance", mock.Anything, &definitions.MuteTimeInterval{MuteTimeInterval: config.MuteTimeInterval(timingToDelete)}, orgID) }) t.Run("deletes mute timing and provenance by UID", func(t *testing.T) { sut, store, prov := createMuteTimingSvcSut() store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return &legacy_storage.ConfigRevision{Config: initialConfig()}, nil } store.SaveFn = func(ctx context.Context, revision *legacy_storage.ConfigRevision) error { assertInTransaction(t, ctx) return nil } prov.EXPECT().GetProvenance(mock.Anything, mock.Anything, mock.Anything).Return(models.ProvenanceNone, nil) prov.EXPECT().DeleteProvenance(mock.Anything, mock.Anything, mock.Anything).RunAndReturn( func(ctx context.Context, _ models.Provisionable, _ int64) error { assertInTransaction(t, ctx) return nil }) uid := legacy_storage.NameToUid(timingToDelete.Name) err := sut.DeleteMuteTiming(context.Background(), uid, orgID, "", correctVersion) require.NoError(t, err) require.Len(t, store.Calls, 2) require.Equal(t, "Get", store.Calls[0].Method) require.Equal(t, orgID, store.Calls[0].Args[1]) require.Equal(t, "Save", store.Calls[1].Method) require.Equal(t, orgID, store.Calls[1].Args[2]) revision := store.Calls[1].Args[1].(*legacy_storage.ConfigRevision) expectedMuteTimings := slices.DeleteFunc(initialConfig().AlertmanagerConfig.MuteTimeIntervals, func(interval config.MuteTimeInterval) bool { return interval.Name == timingToDelete.Name }) require.EqualValues(t, expectedMuteTimings, revision.Config.AlertmanagerConfig.MuteTimeIntervals) prov.AssertCalled(t, "DeleteProvenance", mock.Anything, &definitions.MuteTimeInterval{MuteTimeInterval: timingToDelete}, orgID) }) t.Run("propagates errors", func(t *testing.T) { t.Run("when unable to read config", func(t *testing.T) { sut, store, prov := createMuteTimingSvcSut() expectedErr := errors.New("test-err") prov.EXPECT().GetProvenance(mock.Anything, mock.Anything, mock.Anything).Return(models.ProvenanceNone, nil) store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return nil, expectedErr } err := sut.DeleteMuteTiming(context.Background(), timingToDelete.Name, orgID, "", "") require.ErrorIs(t, err, expectedErr) }) t.Run("when provenance fails to save", func(t *testing.T) { sut, store, prov := createMuteTimingSvcSut() prov.EXPECT().GetProvenance(mock.Anything, mock.Anything, mock.Anything).Return(models.ProvenanceNone, nil) store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return &legacy_storage.ConfigRevision{Config: initialConfig()}, nil } expectedErr := fmt.Errorf("failed to save provenance") sut.provenanceStore.(*MockProvisioningStore).EXPECT(). DeleteProvenance(mock.Anything, mock.Anything, mock.Anything). Return(expectedErr) err := sut.DeleteMuteTiming(context.Background(), timingToDelete.Name, orgID, "", "") require.ErrorIs(t, err, expectedErr) require.Len(t, store.Calls, 2) require.Equal(t, "Get", store.Calls[0].Method) require.Equal(t, orgID, store.Calls[0].Args[1]) require.Equal(t, "Save", store.Calls[1].Method) }) t.Run("when AM config fails to save", func(t *testing.T) { sut, store, prov := createMuteTimingSvcSut() prov.EXPECT().GetProvenance(mock.Anything, mock.Anything, mock.Anything).Return(models.ProvenanceNone, nil) store.GetFn = func(ctx context.Context, orgID int64) (*legacy_storage.ConfigRevision, error) { return &legacy_storage.ConfigRevision{Config: initialConfig()}, nil } expectedErr := errors.New("test-err") store.SaveFn = func(ctx context.Context, revision *legacy_storage.ConfigRevision) error { return expectedErr } err := sut.DeleteMuteTiming(context.Background(), timingToDelete.Name, orgID, "", "") require.ErrorIs(t, err, expectedErr) require.Len(t, store.Calls, 2) require.Equal(t, "Get", store.Calls[0].Method) require.Equal(t, orgID, store.Calls[0].Args[1]) require.Equal(t, "Save", store.Calls[1].Method) }) }) } func createMuteTimingSvcSut() (*MuteTimingService, *legacy_storage.AlertmanagerConfigStoreFake, *MockProvisioningStore) { store := &legacy_storage.AlertmanagerConfigStoreFake{} prov := &MockProvisioningStore{} return &MuteTimingService{ configStore: store, provenanceStore: prov, xact: newNopTransactionManager(), log: log.NewNopLogger(), validator: func(from, to models.Provenance) error { return nil }, ruleNotificationsStore: &fakeAlertRuleNotificationStore{}, }, store, prov }